Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(insights): remove unused reportCohortCreatedFromPersonsModal #23085

Merged

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Jun 19, 2024

Problem

The code path is obsolete

Changes

Removes it (stacked on top of #23084)

How did you test this code?

n/a

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Size Change: -158 B (-0.01%)

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.06 MB -158 B (-0.01%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr changed the title wip refactor(insights): remove unused reportCohortCreatedFromPersonsModal Jun 19, 2024
@thmsobrmlr thmsobrmlr changed the title refactor(insights): remove unused reportCohortCreatedFromPersonsModal refactor(insights): remove unused reportCohortCreatedFromPersonsModal Jun 19, 2024
@thmsobrmlr thmsobrmlr marked this pull request as ready for review June 19, 2024 14:53
@PostHog PostHog deleted a comment from posthog-bot Jun 19, 2024
@thmsobrmlr thmsobrmlr requested a review from a team June 19, 2024 15:04
@thmsobrmlr
Copy link
Contributor Author

Going to YOLO this with #23084

@thmsobrmlr thmsobrmlr merged commit 508a03c into insight-usage-reporting-rebased Jun 24, 2024
94 of 95 checks passed
@thmsobrmlr thmsobrmlr deleted the remove-report-cohort-from-actors branch June 24, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants